-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Enforce use of ordered edges #3095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3095 +/- ##
========================================
Coverage 74.58% 74.58%
========================================
Files 231 231
Lines 26812 26812
========================================
Hits 19998 19998
Misses 6814 6814 ☔ View full report in Codecov by Sentry. |
5a50acb
to
7574352
Compare
OceanNuclear
added a commit
that referenced
this pull request
Jul 6, 2024
OceanNuclear
added a commit
that referenced
this pull request
Jul 9, 2024
57baa8f
to
bcfa110
Compare
bcfa110
to
d9ab1e6
Compare
|
OceanNuclear
added a commit
that referenced
this pull request
Jul 9, 2024
oliverfunk
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #3037
Description
The deserialiser is not necessarily stable but in 3037 there was a second bug because
Edges
overOrderedEdges
was used.Interface Changes
Checklist
I confirm that I have completed the following checks:
pytest tests --reactor
pre-commit run --from-ref develop --to-ref HEAD
sphinx-build -W documentation/source documentation/build