Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Enforce use of ordered edges #3095

Merged
merged 4 commits into from
Jul 26, 2024
Merged

🐛 Enforce use of ordered edges #3095

merged 4 commits into from
Jul 26, 2024

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Mar 13, 2024

Linked Issues

Closes #3037

Description

The deserialiser is not necessarily stable but in 3037 there was a second bug because Edges over OrderedEdges was used.

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook requested review from a team as code owners March 13, 2024 14:14
Copy link
Contributor

github-actions bot commented Mar 13, 2024

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (5)

On runtest

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead

On collect

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (504f296) to head (d9ab1e6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3095   +/-   ##
========================================
  Coverage    74.58%   74.58%           
========================================
  Files          231      231           
  Lines        26812    26812           
========================================
  Hits         19998    19998           
  Misses        6814     6814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@je-cook je-cook mentioned this pull request Mar 14, 2024
3 tasks
@je-cook je-cook marked this pull request as draft March 14, 2024 11:19
@je-cook je-cook force-pushed the develop branch 5 times, most recently from 5a50acb to 7574352 Compare May 15, 2024 08:13
@OceanNuclear OceanNuclear marked this pull request as ready for review July 9, 2024 15:10
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@je-cook je-cook added bug Something isn't working geometry Tasks relating to the geometry module labels Jul 10, 2024
@je-cook je-cook added this to the Version 2.2.0 milestone Jul 26, 2024
@oliverfunk oliverfunk merged commit 0f891a2 into develop Jul 26, 2024
8 checks passed
@oliverfunk oliverfunk deleted the je-cook/edges branch July 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working geometry Tasks relating to the geometry module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Part Wire needs a specific ordering to reconstruct wire using deserialise_shape
3 participants