Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook Event user.registration.update.complete not sending updated roles #1898

Closed
sjswami opened this issue Sep 26, 2022 · 4 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sjswami
Copy link

sjswami commented Sep 26, 2022

Event user.registration.update.complete not sending updated roles

Description

The Webhook event user.registration.update.complete is invoked with any user role is added into the registed app. In event we are not receiving the new added role name. And on removing a role, in the webhook event data we are getting Role name which is removed.

Affects versions

1.40

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to Webooks and enable the user.registration.update.complete event. Also enable in Tenant
  2. Click on User
  3. Click on Manage
  4. On Application click Edit
  5. Select a Role and click on save
  6. Observe the Event object event.original.roles
  7. Value will be empty array which is as expected
  8. Observe the Event object event.registration.roles
  9. Value will be empty array which is not expected, role name should appear

Expected behavior

In the event object event.registration.roles newly selected event name should come in array

Screenshots

image

Platform

(Please complete the following information)

  • Device: Desktop
  • OS: Windows
  • Browser chrome + latest version [e.g. chrome, safari plus a version]
  • Database [PostgresSQL] & and 12.12

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

Additional context

None

@mooreds mooreds added the bug Something isn't working label Sep 29, 2022
@mooreds
Copy link
Collaborator

mooreds commented Sep 29, 2022

Thanks for filing @sjswami !

I have replicated this on 1.40.1.

The value in event.original.roles is the same as the value in event.registration.roles, when the latter should be the new role.

You can see this here: https://requestbin.com/r/en46qikwl3yl7/2FRgrfdDa6Erau1brjgReHp21Lb

To replicate:

  • set up a user.registration.update.complete webhook listener.
  • modify a user's role using the admin UI
  • modify the user's role again

Expected: the new role shows up under registrations. Reality: old role shows up in both places.

@robotdan robotdan added this to Backlog in FusionAuth Issues via automation Jan 9, 2023
@robotdan robotdan added this to the 1.43.0 milestone Jan 9, 2023
@robotdan robotdan modified the milestones: 1.43.0, 1.44.0 Jan 30, 2023
@robotdan
Copy link
Member

Internal:

  • Review entire user and registration object being sent in this event. Check for custom user data, custom registration data and roles.

@robotdan robotdan removed this from the 1.44.0 milestone Feb 28, 2023
@sjswami
Copy link
Author

sjswami commented Mar 9, 2023

Any progress in fixing this bug. When we can expect to be released.

@lyleschemmerling
Copy link

@lyleschemmerling lyleschemmerling moved this from Backlog to Internal Review in FusionAuth Issues Jul 14, 2023
@robotdan robotdan moved this from Internal Review to Reviewer approved in FusionAuth Issues Jul 19, 2023
@robotdan robotdan added this to the 1.47.0 milestone Jul 19, 2023
FusionAuth Issues automation moved this from Reviewer approved to Done Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
FusionAuth Issues
  
Delivered
Development

No branches or pull requests

5 participants