Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing WebHookIds on the Tenant Request #1984

Closed
mooreds opened this issue Nov 28, 2022 · 4 comments
Closed

Missing WebHookIds on the Tenant Request #1984

mooreds opened this issue Nov 28, 2022 · 4 comments
Assignees
Milestone

Comments

@mooreds
Copy link
Collaborator

mooreds commented Nov 28, 2022

Missing WebHookIds on the Tenant Request

Description

The Tenant request json here: https://github.com/FusionAuth/fusionauth-client-builder/blob/master/src/main/api/updateTenant.json (for example), doesn't include all

Affects versions

Any version after 1.37, which is when webhookids were added to the tenant object, to address #1812

Steps to reproduce

Try to create a tenant request with webhookids using the go client library.

Expected behavior

This parameter should be available on all types of tenant request (create, update, retrieve).

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

Additional context

Originally reported by @sjauld here: FusionAuth/go-client#70

@robotdan robotdan added the bug Something isn't working label Dec 8, 2022
@robotdan robotdan added this to Backlog in FusionAuth Issues via automation Dec 8, 2022
@robotdan robotdan added this to the 1.43.0 milestone Dec 8, 2022
@lyleschemmerling
Copy link

@mooreds Looks to me that the webhook ids are on all of the TenantRequest typed objects in the clients and those are used in the create and update requests so I don't think there is an actual issue here. Please double-check but I think we can close this one.

@lyleschemmerling lyleschemmerling added works on my machine and removed bug Something isn't working labels Dec 8, 2022
@mooreds
Copy link
Collaborator Author

mooreds commented Dec 8, 2022

Ah, I may have missed that. I thought it was top level, but there it is on the TenantRequest object.

@lyleschemmerling did you the recreate steps? Were you able to add a webhook with webhook ids using the golang client and the tenant request object?

@lyleschemmerling
Copy link

@mooreds Dan yes I did run the go client and the java client and was able to successfully create a tenant with a webhook using the webhook ids parameter. So I think that we are good!

@mooreds
Copy link
Collaborator Author

mooreds commented Dec 8, 2022

Great, thanks! Appreciate the double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
FusionAuth Issues
  
Delivered
Development

No branches or pull requests

3 participants