Google IdP may not load JavaScript with application override

[spwitt]

Google IdP does not follow application override for login method

Description

If the Google IdP is configured to "Use Redirect" for the login method, and the application override is "Use Popup" or "Use JavaScript," the supporting JavaScript is not loaded.

During resolution and testing for the issue described above, other configuration issues were identified. The API and button properties for the application overrides were not being handled correctly.

The Helper.js file for IdPs should also be loaded up front rather than loaded dynamically from other JavaScript.

Affects versions

1.44.0

Steps to reproduce

1. Set base Google IdP to "Use Redirect" for login method
2. Add an application override that sets login method to "Use Popup"
3. JavaScript for Google sign in is not loaded on the /oauth2/authorize page

Expected behavior

1. The JavaScript should be loaded based on the application override.
2. The Helper.js file should be loaded up front rather than appended to the DOM from JavaScript
3. The application-level API and button properties should be merged with the base configuration

Workaround

In the Helpers file in your theme, find the following line:

[#if identityProviders["Google"]?has_content && identityProviders["Google"][0].loginMethod != "UseRedirect"]

and replace it with

[#if identityProviders["Google"]?has_content && identityProviders["Google"][0].lookupLoginMethod(clientId) != "UseRedirect"]

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

Additional context

Add any other context about the problem here.

Documentation

• Override ux_mode=redirect when loginMethod is UsePopup
• Individual property overrides for Application-specific settings

This PR covers doc tasks:

• Add notes on overriding Google IdP Properties fusionauth-site#2088

[spwitt]

Internal

• https://github.com/FusionAuth/fusionauth-app/pull/233