Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard for authorized origin URLs gives invalid origin error #2227

Closed
beezerk23 opened this issue Apr 21, 2023 · 5 comments
Closed

Wildcard for authorized origin URLs gives invalid origin error #2227

beezerk23 opened this issue Apr 21, 2023 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@beezerk23
Copy link

beezerk23 commented Apr 21, 2023

##Wildcard for authorized origin URLs gives invalid origin error

Description

I think the latest update may have broke something regarding the wildcard for authorized origin urls. When i have https://*.example.com in my authorized origin urls, a request from https://foo.example.com produces this:
Invalid origin uri https://foo.example.com/

I know that there is a trailing slash in the origin uri but i think this should not affect this.

However if i add the full domain to the authorized origin urls it will work and does not produce any error.

Affects versions

1.45.1

Steps to reproduce

Should be clear from the description.

Expected behavior

That the wildcard works as expected.

Related

@robotdan robotdan self-assigned this Apr 21, 2023
@robotdan robotdan added this to the 1.45.2 milestone Apr 21, 2023
@robotdan robotdan added this to Backlog in FusionAuth Issues via automation Apr 21, 2023
@robotdan robotdan moved this from Backlog to In progress in FusionAuth Issues Apr 21, 2023
@robotdan
Copy link
Member

@robotdan robotdan moved this from In progress to Code complete in FusionAuth Issues Apr 21, 2023
@robotdan
Copy link
Member

Thanks for letting us know @beezerk23 - this is most likely occuring on a GET request to FusionAuth. In this case we fall back to the Referer header if the Origin is not present.

When using wild cards we take the entire value for matching, so we need to remove any path or query parameters from this value before validating.

@robotdan robotdan added the bug Something isn't working label Apr 21, 2023
@robotdan robotdan moved this from Code complete to Reviewer approved in FusionAuth Issues Apr 21, 2023
@beezerk23
Copy link
Author

Hey @robotdan, can you give me any inside on when this is going to be released?

@robotdan robotdan modified the milestones: 1.45.2, 1.46.0 May 9, 2023
@robotdan
Copy link
Member

Sorry for the delay, this is available in an early build, now, and the full release is coming today or tomorrow.

@robotdan robotdan moved this from Reviewer approved to Done in FusionAuth Issues Jun 20, 2023
@robotdan
Copy link
Member

@beezerk23 thanks for your patience. Fix is available in 14.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
FusionAuth Issues
  
Delivered
Development

No branches or pull requests

2 participants