Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email MFA codes sporadically being sent multiple times during password resets #2253

Closed
lyleschemmerling opened this issue May 5, 2023 · 4 comments
Labels
bug Something isn't working client-reported duplicate This issue or pull request already exists

Comments

@lyleschemmerling
Copy link

Email MFA codes sporadically being sent multiple times during password resets

Description

Given a user registered to an application and that has email MFA enabled, when a password reset email is sent and the user clicks on the link in the email they are occasionally sent multiple MFA codes via email. The codes are distinct and only the latest is valid. This is does not always happen, sometimes one code is sent and on occasion I have seen more than two.

I have validated that this is not a result of multiple API calls or redirects from the browser, sometimes the second code takes a few seconds to be sent after the first. Nothing in the logs indicates an error.

Affects versions

Found on 1.42.1, as of yet unable to reproduce on 1.45.1

Steps to reproduce

Steps to reproduce the behavior:

  1. Create a user
  2. Register the user for an application
  3. Set up email MFA for the user via api
  4. In the Admin UI send the user a password reset email
  5. As the user click the link in the email

Expected behavior

Only one MFA code should be sent

Platform

(Please complete the following information)

  • Device: MacBook Pro M2
  • OS: macOS
  • Browser: Chrome and Firefox

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

Additional context

Seen on a staging system, I have not been able to reproduce myself yet on the latest code.

@lyleschemmerling lyleschemmerling added the bug Something isn't working label May 8, 2023
@robotdan robotdan added this to Backlog in FusionAuth Issues via automation May 29, 2023
@robotdan
Copy link
Member

We should account for HEAD and GET requests in this path that may be used by spam/phishing filters.

See /email/verify, /registration/verify and /oauth2/passwordless.

This was likely introduced when we began enforcing 2FA prior to a password change.

@smt
Copy link

smt commented Jun 7, 2023

@lyleschemmerling We're on 1.45.2 now, and still able to reproduce the issue.

@spwitt spwitt added the duplicate This issue or pull request already exists label Jul 19, 2023
@spwitt
Copy link

spwitt commented Jul 19, 2023

It looks like I created a duplicate issue based on a customer report

@lyleschemmerling can you confirm they are duplicates before we close this issue?

@robotdan robotdan removed this from Backlog in FusionAuth Issues Aug 30, 2023
@robotdan
Copy link
Member

Assuming this is a duplicate as mentioned. Please re-open if there is a new use case here that is not covered by existing solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client-reported duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants