Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send setup password email sent even if webhook fails the transaction #2287

Closed
robotdan opened this issue May 28, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@robotdan
Copy link
Member

robotdan commented May 28, 2023

Send setup password email sent even if webhook fails the transaction

Description

When sending a set up password email as part of a user create, if a webhook is configured to be transactional, the email may still be sent even if the wehook fails rolling back the transaction.

Observed in version

1.45.0

Affects versions

TBD

Steps to reproduce

  1. Enable user.create webhook with All webhooks must succeed
  2. Enable the Setup Password email template
  3. Create user+registration using the /api/user/registration/{userId} API, setting sendSetPasswordEmail to true
  4. Have the webhook return a non-2xx status code

Observation:

  1. API returns 504 indicating the webhook transaction failed
  2. User is not created
  3. User receives the set password email

Expected behavior

Email should not be sent if the webhook fails.

Related

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

Additional context

Add any other context about the problem here.

@robotdan robotdan added the bug Something isn't working label May 28, 2023
@robotdan robotdan added this to Backlog in FusionAuth Issues via automation May 28, 2023
@robotdan
Copy link
Member Author

@robotdan robotdan added this to the 1.46.0 milestone May 30, 2023
@robotdan robotdan moved this from Backlog to Code complete in FusionAuth Issues May 30, 2023
@robotdan robotdan self-assigned this May 30, 2023
@robotdan robotdan closed this as completed Jun 2, 2023
FusionAuth Issues automation moved this from Code complete to Done Jun 2, 2023
@robotdan robotdan reopened this Jun 2, 2023
FusionAuth Issues automation moved this from Done to In progress Jun 2, 2023
@robotdan robotdan moved this from In progress to Reviewer approved in FusionAuth Issues Jun 2, 2023
@robotdan robotdan moved this from Reviewer approved to Done in FusionAuth Issues Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
FusionAuth Issues
  
Delivered
Development

No branches or pull requests

1 participant