Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS bug when enabling MFA during login #2296

Closed
robotdan opened this issue May 31, 2023 · 1 comment
Closed

Fix JS bug when enabling MFA during login #2296

robotdan opened this issue May 31, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@robotdan
Copy link
Member

robotdan commented May 31, 2023

Fix JS bug when enabling MFA during login

Description

When email MFA is not enabled, you may see an exception in the JS console.

Uncaught TypeError: Cannot read properties of null (reading 'querySelector')
    at #handleOnSubmit (OAuth2TwoFactorEnable.js?version=1.45.3:40:34)
#handleOnSubmit @ OAuth2TwoFactorEnable.js?version=1.45.3:40

Observed in version

1.45.3

Affects versions

TBD

Workaround

This error should only be causing noise on the JS console. If you want to fix it, and you are only using OTP and not Email or SMS, add this to the template to work around the JS error.

 <form id="send-two-factor-form" action="${request.contextPath}/oauth2/two-factor-enable" method="POST" ></form>

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

Additional context

Add any other context about the problem here.

@robotdan robotdan self-assigned this May 31, 2023
@robotdan robotdan added the bug Something isn't working label May 31, 2023
@robotdan robotdan added this to Backlog in FusionAuth Issues via automation May 31, 2023
@robotdan robotdan added this to the 1.46.0 milestone May 31, 2023
@robotdan robotdan moved this from Backlog to In progress in FusionAuth Issues May 31, 2023
@robotdan robotdan moved this from In progress to Code complete in FusionAuth Issues May 31, 2023
@robotdan
Copy link
Member Author

@robotdan robotdan closed this as completed Jun 2, 2023
FusionAuth Issues automation moved this from Code complete to Done Jun 2, 2023
@robotdan robotdan reopened this Jun 2, 2023
FusionAuth Issues automation moved this from Done to In progress Jun 2, 2023
@robotdan robotdan moved this from In progress to Reviewer approved in FusionAuth Issues Jun 2, 2023
@robotdan robotdan moved this from Reviewer approved to Done in FusionAuth Issues Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
FusionAuth Issues
  
Delivered
Development

No branches or pull requests

1 participant