Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie SameSite Configuration or default behavior #537

Closed
robotdan opened this issue Mar 25, 2020 · 1 comment
Closed

Cookie SameSite Configuration or default behavior #537

robotdan opened this issue Mar 25, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@robotdan
Copy link
Member

robotdan commented Mar 25, 2020

Cookie SameSite Configuration or default behavior

Description

Chrome and other browsers are starting to require cookies contain the SameSite attribute.
This is not currently available in the Java Servlet 3.1 or 4.0 specification.

This only affects cookies that are not marked as secure which means the connection is not using TLS.

Deprecate and remove the use of cookies with the SameSite=None attribute but without the Secure attribute. Any cookie that requests SameSite=None but is not marked Secure will be rejected.

https://www.chromestatus.com/feature/5633521622188032

More recent versions of Apache Tomcat do seem to have some support for this capability.

It is also possible to manually write the Set-Cookie header, but this has a bunch of problems as well.

Additional context

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie

This PR may contain what we need, we'll see if we can pick this up without moving to Tomcat 9 or 10.
apache/tomcat#162

https://security.stackexchange.com/a/187671/188227

https://www.chromestatus.com/feature/5088147346030592

@robotdan robotdan added this to Backlog in FusionAuth Issues via automation Mar 25, 2020
@robotdan robotdan self-assigned this Mar 25, 2020
@robotdan robotdan moved this from Backlog to In progress in FusionAuth Issues Mar 26, 2020
@robotdan robotdan added this to the 1.16.0 milestone Mar 26, 2020
@robotdan robotdan added the enhancement New feature or request label Mar 26, 2020
@robotdan robotdan modified the milestones: 1.16.0, 1.15.6 Mar 27, 2020
@robotdan robotdan moved this from In progress to Reviewer approved in FusionAuth Issues Mar 27, 2020
@robotdan robotdan moved this from Reviewer approved to Done in FusionAuth Issues Mar 27, 2020
@jon-at-advarra
Copy link

@robotdan Just an FYI that Firefox is starting to warn for unsecure cookies w/o SameSite set:
image (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
FusionAuth Issues
  
Delivered
Development

No branches or pull requests

2 participants