Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upgrade guide improvements #2166

Closed
wants to merge 43 commits into from

Conversation

sixhobbits
Copy link
Collaborator

@sixhobbits sixhobbits commented May 12, 2023

based on #1951

@mooreds - sorry this one took a while - there is still a lot more we could add, but want to check if this is in the right direction as it's pretty different from the other posts we have done.

NOTES:

  • We haven't done the theme upgrade tooling
  • We can still show a step-by-step guide for a Kubernetes cluster in the more practical second section
  • The diagrams are images, but we can do plantuml versions still

@sixhobbits sixhobbits requested a review from mooreds May 12, 2023 08:28
@mooreds mooreds added the content large piece of content label May 16, 2023
site/docs/v1/tech/admin-guide/upgrade.adoc Outdated Show resolved Hide resolved
site/docs/v1/tech/admin-guide/upgrade.adoc Outdated Show resolved Hide resolved
site/docs/v1/tech/admin-guide/upgrade.adoc Outdated Show resolved Hide resolved
site/docs/v1/tech/admin-guide/upgrade.adoc Outdated Show resolved Hide resolved
site/docs/v1/tech/admin-guide/upgrade.adoc Outdated Show resolved Hide resolved

To upgrade to the latest version of FusionAuth using Docker go link:/docs/v1/tech/installation-guide/docker[here].
To upgrade to the latest version of FusionAuth using Docker, go link:/docs/v1/tech/installation-guide/docker[here].

If you want to use manual mode, download the latest version of FusionAuth and follow the instructions below. See https://fusionauth.io/download[Downloads].
====

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing cloud update and k8s update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're okay leaving k8s update off, but can you link to the cloud upgrade section: https://fusionauth.io/docs/v1/tech/installation-guide/cloud#upgrading-a-deployment


[NOTE]
====
*Readme*

To upgrade to the latest version of FusionAuth using the FastPath installation go link:/docs/v1/tech/installation-guide/fast-path[here].
To upgrade to the latest version of FusionAuth using the FastPath installation, go link:/docs/v1/tech/installation-guide/fast-path[here].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably get rid of this, since we advise against using FastPath in prod below.


To upgrade to the latest version of FusionAuth using Homebrew go link:/docs/v1/tech/installation-guide/homebrew[here].
To upgrade to the latest version of FusionAuth using Homebrew, go link:/docs/v1/tech/installation-guide/homebrew[here].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we extract out the homebrew upgrade instructions to a shared file and include them here and there?


To upgrade to the latest version of FusionAuth using Docker go link:/docs/v1/tech/installation-guide/docker[here].
To upgrade to the latest version of FusionAuth using Docker, go link:/docs/v1/tech/installation-guide/docker[here].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we extract out the docker upgrade instructions to a shared file and include them here and there?


== Database
=== Database
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplicative?

@mooreds
Copy link
Contributor

mooreds commented May 26, 2023

This is a great start. Themes are tough. Here's what I'd do:

  • pull down the default theme from your current version
  • pull down the default theme from your target version
  • diff them
  • see what changes you need to make to your customized theme (adding messages, files, parameters)

Should probably add in a support CTA (forums, account.fusionauth.io/account/support).

sixhobbits and others added 11 commits June 1, 2023 10:16
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
@mooreds
Copy link
Contributor

mooreds commented Jun 15, 2023

Is this ready for re-review @sixhobbits ?

@sixhobbits
Copy link
Collaborator Author

@mooreds no sorry we are still figuring out the theme import stuff.

@mooreds
Copy link
Contributor

mooreds commented Jun 16, 2023

@sixhobbits Awesome, no worries, wanted to check on status. Feel free to ask questions here and in slack; I remember we talked about how some of the upgrade guide was pretty domain specific.

FYI, there's a node cli @ColinFrick wrote that makes the theme upload/download much easier. Would prefer if you'd use that: https://github.com/FusionAuth/fusionauth-node-cli rather than write your own or use curl.

@sixhobbits
Copy link
Collaborator Author

dependent on FusionAuth/fusionauth-theme-helper#8

@sixhobbits sixhobbits requested a review from mooreds June 22, 2023 07:20
@sixhobbits
Copy link
Collaborator Author

@mooreds we have implemented all the feedback now.

Still outstanding is Cloud + Kubernetes, but as discussed on Slack we can do that as a follow on as it will be quite a big project too to test everything out.

Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer!

site/docs/v1/tech/admin-guide/upgrade.adoc Show resolved Hide resolved
site/docs/v1/tech/admin-guide/upgrade.adoc Outdated Show resolved Hide resolved
site/docs/v1/tech/admin-guide/upgrade.adoc Outdated Show resolved Hide resolved

To upgrade to the latest version of FusionAuth using the FastPath installation go link:/docs/v1/tech/installation-guide/fast-path[here].
The timing of the database upgrade is also important to note. When an upgraded node is started and connects to the database, it will lock the database immediately if configured for Silent Mode and the database requires upgrading. This means that the database will be unavailable to other nodes in the cluster until the upgrade is complete.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first mention of Silent Mode and might be confusing. Can you talk about modes before this so folks don't get confused? The two modes that need to be covered are silent mode and runtime mode.

site/docs/v1/tech/admin-guide/upgrade.adoc Show resolved Hide resolved

To upgrade to the latest version of FusionAuth using Docker go link:/docs/v1/tech/installation-guide/docker[here].
To upgrade to the latest version of FusionAuth using Docker, go link:/docs/v1/tech/installation-guide/docker[here].

If you want to use manual mode, download the latest version of FusionAuth and follow the instructions below. See https://fusionauth.io/download[Downloads].
====

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're okay leaving k8s update off, but can you link to the cloud upgrade section: https://fusionauth.io/docs/v1/tech/installation-guide/cloud#upgrading-a-deployment

site/docs/v1/tech/installation-guide/_theme-upgrade.adoc Outdated Show resolved Hide resolved
site/docs/v1/tech/installation-guide/_theme-upgrade.adoc Outdated Show resolved Hide resolved
site/docs/v1/tech/installation-guide/_theme-upgrade.adoc Outdated Show resolved Hide resolved
site/docs/v1/tech/installation-guide/_theme-upgrade.adoc Outdated Show resolved Hide resolved
sixhobbits and others added 4 commits August 1, 2023 10:11
Co-authored-by: Dan Moore <dan@fusionauth.io>
Co-authored-by: Dan Moore <dan@fusionauth.io>
# Conflicts:
#	site/docs/v1/tech/installation-guide/docker.adoc
@mooreds
Copy link
Contributor

mooreds commented Aug 2, 2023

Please let me know when this is ready for re-review.

Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to close under #2461

@mooreds mooreds closed this Aug 16, 2023
@mooreds mooreds mentioned this pull request Sep 22, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content large piece of content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants