-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(breadcrumb): replace 'strong' with 'breadcrumb' tags #3043
base: main
Are you sure you want to change the base?
Conversation
…tro-breadcrumb # Conflicts: # astro/src/content/docs/_shared/_admin-user-form.mdx # astro/src/content/docs/_shared/_admin-user-registration-form.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - so many breadcrumbs, I feel like a duck!
thanks for the review @tonyblank while merging the latest updates i found a mistake in a few changes we did where it should have been replaced with |
…o-breadcrumb # Conflicts: # astro/src/content/docs/customize/email-and-messages/configure-email.mdx # astro/src/content/docs/customize/look-and-feel/index.mdx # astro/src/content/docs/extend/events-and-webhooks/signing.mdx
@alex-fusionauth I've merged the latest changes and updated some newly introduced The few ones unclear right now are the ones where it refers to navigate to a section rather a full page/tab. |
@alex-fusionauth defined the sections as a |
Here is a file of lines that in most cases need |
astro/src/content/docs/customize/email-and-messages/generic-messenger.mdx
Outdated
Show resolved
Hide resolved
astro/src/content/docs/customize/email-and-messages/messengers.mdx
Outdated
Show resolved
Hide resolved
@@ -43,22 +44,22 @@ You can review our [Technical Support documentation](/docs/operate/troubleshooti | |||
|
|||
### In PagerDuty | |||
|
|||
1. The _Account Owner_ can configure the SSO settings by navigating to <strong>User Icon -> Account Settings -> Single Sign-On</strong>. | |||
1. The _Account Owner_ can configure the SSO settings by navigating to <Breadcrumb>User Icon -> Account Settings -> Single Sign-On</Breadcrumb>. | |||
2. Select the **SAML** radio button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a InlineUIElement
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's in pagerduty? https://support.pagerduty.com/docs/sso, from what i understand this counts as a Breadcrumb "If you can click on something and go somewhere (like a tab)"
...ntent/docs/lifecycle/manage-users/account-management/_account-management-troubleshooting.mdx
Outdated
Show resolved
Hide resolved
...ntent/docs/lifecycle/manage-users/verification/registration-gate-accounts-until-verified.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy Pai <andy.pai@gmail.com>
solves issue FusionAuth/fusionauth-issues#2572