Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(breadcrumb): replace 'strong' with 'breadcrumb' tags #3043

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

escii
Copy link
Collaborator

@escii escii commented Apr 28, 2024

@escii escii requested a review from tonyblank April 28, 2024 23:30
…tro-breadcrumb

# Conflicts:
#	astro/src/content/docs/_shared/_admin-user-form.mdx
#	astro/src/content/docs/_shared/_admin-user-registration-form.mdx
Copy link

@tonyblank tonyblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - so many breadcrumbs, I feel like a duck!

@Aaron-Ritter
Copy link
Collaborator

Aaron-Ritter commented May 18, 2024

thanks for the review @tonyblank while merging the latest updates i found a mistake in a few changes we did where it should have been replaced with <UIelement></UIelement> instead.

@Aaron-Ritter
Copy link
Collaborator

@alex-fusionauth I've merged the latest changes and updated some newly introduced <strong> tags and we are ready to merge. As discussed, while reviewing for any other changes the single step navigation instructions. I've update all these accordingly as well with the <Breadcrumb> tag.

The few ones unclear right now are the ones where it refers to navigate to a section rather a full page/tab.

@Aaron-Ritter
Copy link
Collaborator

@alex-fusionauth defined the sections as a <InlineUIElement>

@andrewpai
Copy link
Collaborator

andrewpai commented Jul 5, 2024

Here is a file of lines that in most cases need <Breadcrumb> instead of some other styling. A few need <InlineUIElement>.
breadcrumbs-needed.txt

astro/src/content/docs/apis/api-explorer.mdx Outdated Show resolved Hide resolved
@@ -43,22 +44,22 @@ You can review our [Technical Support documentation](/docs/operate/troubleshooti

### In PagerDuty

1. The _Account Owner_ can configure the SSO settings by navigating to <strong>User Icon -> Account Settings -> Single Sign-On</strong>.
1. The _Account Owner_ can configure the SSO settings by navigating to <Breadcrumb>User Icon -> Account Settings -> Single Sign-On</Breadcrumb>.
2. Select the **SAML** radio button.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a InlineUIElement?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's in pagerduty? https://support.pagerduty.com/docs/sso, from what i understand this counts as a Breadcrumb "If you can click on something and go somewhere (like a tab)"

Co-authored-by: Andy Pai <andy.pai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants