Add setting for exact alarms

Futsch1 · Feb 18, 2024 · dc14470 · dc14470
1 parent e72605a
commit dc14470
Show file tree

Hide file tree

Showing 7 changed files with 51 additions and 16 deletions.
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -3,6 +3,7 @@
     xmlns:tools="http://schemas.android.com/tools">
 
     <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
+    <uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" />
     <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
 
     <application

diff --git a/app/src/main/feature-graphic-playstore.xcf b/app/src/main/feature-graphic-playstore.xcf
diff --git a/app/src/main/java/com/futsch1/medtimer/PreferencesFragment.java b/app/src/main/java/com/futsch1/medtimer/PreferencesFragment.java
@@ -1,8 +1,8 @@
 package com.futsch1.medtimer;
 
 import static android.Manifest.permission.POST_NOTIFICATIONS;
-import static android.Manifest.permission.SCHEDULE_EXACT_ALARM;
 
+import android.app.AlarmManager;
 import android.app.AlertDialog;
 import android.app.Application;
 import android.content.Intent;
@@ -11,16 +11,16 @@
 import android.os.Bundle;
 import android.os.Handler;
 import android.os.HandlerThread;
+import android.provider.Settings;
 import android.util.Log;
 
-import androidx.activity.result.ActivityResultLauncher;
-import androidx.activity.result.contract.ActivityResultContracts;
 import androidx.core.app.ActivityCompat;
 import androidx.core.content.FileProvider;
 import androidx.lifecycle.ViewModelProvider;
 import androidx.preference.Preference;
 import androidx.preference.PreferenceFragmentCompat;
 import androidx.preference.PreferenceManager;
+import androidx.preference.SwitchPreference;
 
 import com.futsch1.medtimer.database.MedicineRepository;
 import com.futsch1.medtimer.helpers.PathHelper;
@@ -31,15 +31,6 @@
 import java.net.URLConnection;
 
 public class PreferencesFragment extends PreferenceFragmentCompat {
-
-    private final ActivityResultLauncher<String> requestPermissionLauncher = registerForActivityResult(
-            new ActivityResultContracts.RequestPermission(),
-            result -> {
-                if (!result) {
-                    PreferenceManager.getDefaultSharedPreferences(requireContext()).edit().putBoolean("exact_reminders", false).apply();
-                }
-            }
-    );
     private MedicineViewModel medicineViewModel;
     private HandlerThread backgroundThread;
 
@@ -90,8 +81,21 @@ public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
         if (preference != null) {
             preference.setOnPreferenceChangeListener((preference13, newValue) -> {
                 if ((Boolean) newValue) {
-                    if (ActivityCompat.checkSelfPermission(requireContext(), SCHEDULE_EXACT_ALARM) != PackageManager.PERMISSION_GRANTED) {
-                        requestPermissionLauncher.launch(SCHEDULE_EXACT_ALARM);
+                    AlarmManager alarmManager = requireContext().getSystemService(AlarmManager.class);
+                    if (!alarmManager.canScheduleExactAlarms()) {
+                        AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
+                        builder.setTitle(R.string.enable_alarm_dialog).
+                                setPositiveButton(R.string.ok, (dialog, id) -> {
+                                    Intent intent = new Intent(Settings.ACTION_REQUEST_SCHEDULE_EXACT_ALARM);
+                                    requireContext().startActivity(intent);
+                                }).
+                                setNegativeButton(R.string.cancel, (dialog, id) -> {
+                                    PreferenceManager.getDefaultSharedPreferences(requireContext()).edit().putBoolean("exact_reminders", false).apply();
+                                    setPreferenceScreen(null);
+                                    addPreferencesFromResource(R.xml.root_preferences);
+                                });
+
+                        builder.create().show();
                     }
                 }
                 return true;
@@ -131,6 +135,18 @@ public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
         }
     }
 
+    @Override
+    public void onResume() {
+        super.onResume();
+        SwitchPreference preference = getPreferenceScreen().findPreference("exact_reminders");
+        if (preference != null) {
+            AlarmManager alarmManager = requireContext().getSystemService(AlarmManager.class);
+            if (!alarmManager.canScheduleExactAlarms()) {
+                preference.setChecked(false);
+            }
+        }
+    }
+
     @Override
     public void onDestroy() {
         super.onDestroy();

diff --git a/app/src/main/java/com/futsch1/medtimer/reminders/RescheduleWork.java b/app/src/main/java/com/futsch1/medtimer/reminders/RescheduleWork.java
@@ -7,9 +7,11 @@
 import android.app.PendingIntent;
 import android.content.Context;
 import android.content.Intent;
+import android.content.SharedPreferences;
 import android.util.Log;
 
 import androidx.annotation.NonNull;
+import androidx.preference.PreferenceManager;
 import androidx.work.Data;
 import androidx.work.OneTimeWorkRequest;
 import androidx.work.WorkManager;
@@ -62,7 +64,12 @@ private void schedule(Context context, AlarmManager alarmManager, Instant timest
 
             // Cancel potentially already running alarm and set new
             alarmManager.cancel(pendingIntent);
-            alarmManager.setAndAllowWhileIdle(AlarmManager.RTC_WAKEUP, timestamp.toEpochMilli(), pendingIntent);
+
+            if (canScheduleExactAlarms(alarmManager)) {
+                alarmManager.setExactAndAllowWhileIdle(AlarmManager.RTC_WAKEUP, timestamp.toEpochMilli(), pendingIntent);
+            } else {
+                alarmManager.setAndAllowWhileIdle(AlarmManager.RTC_WAKEUP, timestamp.toEpochMilli(), pendingIntent);
+            }
 
             // Notify GUI listener
             NextReminderListener.sendNextReminder(context, reminder.reminderId, timestamp);
@@ -77,4 +84,11 @@ private void schedule(Context context, AlarmManager alarmManager, Instant timest
             WorkManager.getInstance(getApplicationContext()).enqueue(reminderWork);
         }
     }
+
+    private boolean canScheduleExactAlarms(AlarmManager alarmManager) {
+        SharedPreferences sharedPref = PreferenceManager.getDefaultSharedPreferences(getApplicationContext());
+        boolean exactReminders = sharedPref.getBoolean("exact_reminders", true);
+
+        return exactReminders && alarmManager.canScheduleExactAlarms();
+    }
 }
diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml
@@ -53,4 +53,6 @@
     <string name="exact_reminders">Exakte Erinnerungen</string>
     <string name="change_color_toast">Änderungen an den Farben wirken sich nur auf neue Erinnerungen aus</string>
     <string name="permission_not_granted">Berechtigung nicht erteilt</string>
+    <string name="exact_reminders_summary">Erinnerungen werden genau zur eingestellten Zeit erzeugt (erhöhter Batterieverbrauch)</string>
+    <string name="enable_alarm_dialog">Um die Erstellung von exakten Erinnerungen zu ermöglichen, erlaube dies im folgenden Menü</string>
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -54,4 +54,6 @@
     <string name="exact_reminders">Exact reminders</string>
     <string name="change_color_toast">Note that changes in color only take effect in future reminders</string>
     <string name="permission_not_granted">Permission not granted</string>
+    <string name="exact_reminders_summary">Reminders are scheduled at the exact time (increases battery usage)</string>
+    <string name="enable_alarm_dialog">In order to allow scheduling exact alarms, enable this for MedTimer in the following menu</string>
 </resources>
diff --git a/app/src/main/res/xml/root_preferences.xml b/app/src/main/res/xml/root_preferences.xml
@@ -10,8 +10,8 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:defaultValue="false"
+        android:summary="@string/exact_reminders_summary"
         android:title="@string/exact_reminders"
-        app:isPreferenceVisible="false"
         app:key="exact_reminders" />
     <ListPreference
         android:layout_width="wrap_content"