Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesigned warning alert #29

Closed
wants to merge 3 commits into from

Conversation

ShreshthaKriti
Copy link
Member

FIN-21: #21

@benjaminaaron
Copy link
Member

I get Module not found: Can't resolve '@material-ui/lab/Alert'. Did you forget to commit your changes in package.json?

Copy link
Member

@benjaminaaron benjaminaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, cool choice with the Alert package 👍

Can you make the content of the alert box centered? This is how it looks for me and there is empty space on the right side:

Screenshot 2020-02-19 at 17 43 06

Also, as written on the Trello card, it would be great if the box is not in the TopBar but below it. That requires moving it out of TopBar.jsx and somewhere else where it can always be displayed not matter on which subsite the user is. Probably the right place is in App.jsx below <TopBar /> 🤔

src/components/TopBar.jsx Outdated Show resolved Hide resolved
Copy link
Member

@benjaminaaron benjaminaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔹 The addition to package.json is still missing
🔹 Please center the content of the alert box, there is too much empty space on the right side of it
🔹 You forgot to bring along the condition for showing the alert box or not (props.defaultAccount === null). It is now always shown, even when MetaMask is connected to the right network.

src/components/TopBar.jsx Outdated Show resolved Hide resolved
src/components/Warning.jsx Outdated Show resolved Hide resolved
src/components/TopBar.jsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants