-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial zwave_js support #46
Conversation
Here's hoping zwave-js handles code slots better than ozw 👍 |
a3cba19
to
f6b49ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@firstof9 does release drafter have to be installed before this can be merged?
This can't be merged until the next HA release at a minimum, it won't work until that happens |
9fb7507
to
7816029
Compare
The release drafter stuff only deals in the workflow stuff for github, nothing that would halt a merge. |
18ef5fb
to
63c513b
Compare
Tests will fail until 2021.2.0 drops. |
cdf3a4a
to
2c8032e
Compare
8e1b917
to
6de8599
Compare
…rt versions of HA that didn't include zwave_js while adding support
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 91.28% 90.37% -0.91%
==========================================
Files 6 6
Lines 367 395 +28
==========================================
+ Hits 335 357 +22
- Misses 32 38 +6
|
This reverts commit 024eb07.
Proposed change
WIP support for
zwave_js
. Requires upstream support in HA, some changes tozwave-js-server-python
, and a more thorough review, but I wanted to get a draft out there so you could get an early peek at the logic and provide feedback.TODO:
allow_execution
forzwave_js
Type of change
Additional information