Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial zwave_js support #46

Merged
merged 13 commits into from
Feb 1, 2021
Merged

Initial zwave_js support #46

merged 13 commits into from
Feb 1, 2021

Conversation

raman325
Copy link
Collaborator

@raman325 raman325 commented Jan 22, 2021

Proposed change

WIP support for zwave_js. Requires upstream support in HA, some changes to zwave-js-server-python, and a more thorough review, but I wanted to get a draft out there so you could get an early peek at the logic and provide feedback.

TODO:

  • Add tests
  • Look at reducing repeat code by building more helpers
  • Add a new asset to create allow_execution for zwave_js
  • Verify that all of this actually works once zwave_js is live

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

@firstof9 firstof9 added the feature New feature label Jan 22, 2021
@firstof9
Copy link
Collaborator

Here's hoping zwave-js handles code slots better than ozw 👍

Copy link
Owner

@FutureTense FutureTense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@firstof9 does release drafter have to be installed before this can be merged?

@raman325
Copy link
Collaborator Author

This can't be merged until the next HA release at a minimum, it won't work until that happens

@raman325 raman325 force-pushed the zwave_js branch 2 times, most recently from 9fb7507 to 7816029 Compare January 28, 2021 01:23
@firstof9
Copy link
Collaborator

@firstof9 does release drafter have to be installed before this can be merged?

The release drafter stuff only deals in the workflow stuff for github, nothing that would halt a merge.

@raman325 raman325 force-pushed the zwave_js branch 3 times, most recently from 18ef5fb to 63c513b Compare January 29, 2021 07:15
@firstof9
Copy link
Collaborator

Tests will fail until 2021.2.0 drops.

@codecov-io
Copy link

codecov-io commented Jan 31, 2021

Codecov Report

Merging #46 (6eb25a6) into main (5c506ff) will decrease coverage by 0.90%.
The diff coverage is 71.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   91.28%   90.37%   -0.91%     
==========================================
  Files           6        6              
  Lines         367      395      +28     
==========================================
+ Hits          335      357      +22     
- Misses         32       38       +6     
Impacted Files Coverage Δ
custom_components/keymaster/helpers.py 83.78% <58.06%> (-10.12%) ⬇️
custom_components/keymaster/services.py 91.72% <85.18%> (+4.96%) ⬆️
custom_components/keymaster/lock.py 100.00% <100.00%> (ø)

@raman325 raman325 marked this pull request as ready for review January 31, 2021 17:48
@raman325 raman325 marked this pull request as draft January 31, 2021 17:49
@FutureTense FutureTense marked this pull request as ready for review February 1, 2021 23:50
@FutureTense FutureTense merged commit 024eb07 into FutureTense:main Feb 1, 2021
@raman325 raman325 deleted the zwave_js branch February 1, 2021 23:51
FutureTense added a commit that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants