Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access token removal fix on hook removal #109

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

mpsonntag
Copy link
Collaborator

On hook removal the validation hook access tokens for a repository are now only removed, if there are no more remaining active hooks left. Closes #105.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2760451421

  • 33 of 113 (29.2%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 36.7%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/web/fail.go 3 5 60.0%
internal/web/ginutils.go 0 3 0.0%
internal/web/validate.go 12 20 60.0%
internal/web/results.go 6 21 28.57%
internal/web/hooks.go 2 24 8.33%
internal/web/user.go 4 34 11.76%
Files with Coverage Reduction New Missed Lines %
internal/web/user.go 1 16.15%
Totals Coverage Status
Change from base Build 2753139380: -0.1%
Covered Lines: 694
Relevant Lines: 1891

💛 - Coveralls

@mpsonntag mpsonntag merged commit 1f2d701 into G-Node:master Jul 29, 2022
@mpsonntag mpsonntag deleted the hookRemoveFix branch July 29, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hook: check for further hooks before removing access token
2 participants