Skip to content
This repository has been archived by the owner on Dec 14, 2017. It is now read-only.

Dialog view refactoring #102

Merged
merged 8 commits into from
Jun 12, 2015
Merged

Dialog view refactoring #102

merged 8 commits into from
Jun 12, 2015

Conversation

mpsonntag
Copy link
Contributor

  • DialogView has been refactored to provide a base class for two further dialog classes ValueDialogView and SimpleDialogView.
  • ValueDialogView displays a modal window and returns an optional value
  • SimpleDialogView displays a modal window and returns a boolean value
  • ProjectConfigView and ProjectListView have been refactored to extend ValueDialogView
  • RenameIntanceView has been replaced by a more generic StringDialogView
  • AddRDFInstance has been refactored to extend SimpleDialogView

*/
public Optional<T> showDialog(Window window) {
public void showWindow() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this final.

stoewer added a commit that referenced this pull request Jun 12, 2015
@stoewer stoewer merged commit f6b0c56 into G-Node:master Jun 12, 2015
@mpsonntag mpsonntag deleted the refDialogView branch June 12, 2015 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants