Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case insensitive LinkType name in Feature creation #398

Open
achilleas-k opened this issue May 21, 2019 · 5 comments
Open

Support case insensitive LinkType name in Feature creation #398

achilleas-k opened this issue May 21, 2019 · 5 comments

Comments

@achilleas-k
Copy link
Member

achilleas-k commented May 21, 2019

Note by @hkchekc on specifying LinkType in Feature creation after switching to Enums: #395 (comment)

@gicmo while the idea is great and being merged, I just want to note that the by-product (supporting old strings) is not going to work (at least not completely). In the past, the string 'Tagged' with the first letter capitalized works. Now the valid string parameter input should be all lower-case. For example, 'tagged'

Ah true, I guess for that a .lower() call would need to be added now. I have no strong opinion about supporting it (or not). @jgrewe what do you think?

Originally posted by @gicmo in #395 (comment)

@achilleas-k
Copy link
Member Author

Agreement by @jgrewe in #395 (comment)

@jgrewe
Copy link
Member

jgrewe commented May 21, 2019

Relates to all other Enums as well, does it not?

@achilleas-k
Copy link
Member Author

Relates to all other Enums as well, does it not?

The only other new Enum is DimensionType and that was never directly set by the user, so the values never appeared in any other form.

@hkchekc
Copy link
Member

hkchekc commented May 21, 2019

Relates to all other Enums as well, does it not?

The only other new Enum is DimensionType and that was never directly set by the user, so the values never appeared in any other form.

Should we disable or make the dimension_type setter private?

@achilleas-k
Copy link
Member Author

I think we should make it private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants