New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support case insensitive LinkType name in Feature creation #398
Comments
Agreement by @jgrewe in #395 (comment) |
Relates to all other Enums as well, does it not? |
The only other new Enum is DimensionType and that was never directly set by the user, so the values never appeared in any other form. |
Should we disable or make the dimension_type setter private? |
I think we should make it private. |
Note by @hkchekc on specifying LinkType in Feature creation after switching to Enums: #395 (comment)
Ah true, I guess for that a
.lower()
call would need to be added now. I have no strong opinion about supporting it (or not). @jgrewe what do you think?Originally posted by @gicmo in #395 (comment)
The text was updated successfully, but these errors were encountered: