Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old unused functions #435

Open
achilleas-k opened this issue Mar 6, 2020 · 1 comment
Open

Delete old unused functions #435

achilleas-k opened this issue Mar 6, 2020 · 1 comment

Comments

@achilleas-k
Copy link
Member

nixpy/nixio/data_array.py

Lines 186 to 196 in ed22c88

def _get_dimension_by_pos(self, index):
h5dim = self._h5group.open_group("dimensions").open_group(str(index))
dimtype = h5dim.get_attr("dimension_type")
if DimensionType(dimtype) == DimensionType.Sample:
return SampledDimension(h5dim, index)
elif DimensionType(dimtype) == DimensionType.Range:
return RangeDimension(h5dim, index)
elif DimensionType(dimtype) == DimensionType.Set:
return SetDimension(h5dim, index)
else:
raise TypeError("Invalid Dimension object in file.")

Old unused function. Handled by DimensionContainer.

@achilleas-k
Copy link
Member Author

nixpy/nixio/multi_tag.py

Lines 112 to 115 in 1eedabf

def _get_slice(self, data, index):
offset, count = self._get_offset_and_count(data, index)
sl = tuple(slice(o, o + c) for o, c in zip(offset, count))
return sl

Old unused function. Replaced by _calc_data_slices().

@achilleas-k achilleas-k changed the title Mark for deletion: _get_dimension_by_pos() Delete old unused functions Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant