Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify XML header in 'xmlparser' and 'version_converter' #339

Closed
mpsonntag opened this issue Nov 18, 2019 · 0 comments · Fixed by #388
Closed

Unify XML header in 'xmlparser' and 'version_converter' #339

mpsonntag opened this issue Nov 18, 2019 · 0 comments · Fixed by #388
Assignees
@mpsonntag

Comments

@mpsonntag
Copy link
Contributor

Currently the XML header in xmlparser and version_converter is not identical.

We should probably add a util function that provides the XML header and use it in both parser and converter.
@mpsonntag mpsonntag self-assigned this Apr 22, 2020
mpsonntag added a commit to mpsonntag/python-odml that referenced this issue Apr 22, 2020
@mpsonntag
[version_converter] Use xmlparser XML header
385f16b 
Closes G-Node#339.
mpsonntag added a commit to mpsonntag/python-odml that referenced this issue Apr 27, 2020
@mpsonntag
[version_converter] Use xmlparser XML header
d38515f 
Closes G-Node#339.
@mpsonntag mpsonntag mentioned this issue Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpsonntag mpsonntag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor issue fixes and test reorganisation mpsonntag/python-odml
1 participant
@mpsonntag