Add validation for unique IDs within a document #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
approved these changes
Oct 19, 2018
|
@jgrewe do you have time to have a look at this? |
jgrewe
approved these changes
Oct 20, 2018
odml/validation.py
Outdated
| self.obj = obj | ||
| self.msg = msg | ||
| self.type = type | ||
| self.type = rank |
There was a problem hiding this comment.
if we use 'rank' in the user facing api, should we also rename type to rank?
There was a problem hiding this comment.
Indeed we should!
|
Good to merge (when the tests finish)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for #258 this PR introduces validation checks for duplicate IDs within a document.
Update:
The github.io documentation now also features the latest version of the data model and a brief description of the commandline convenience scripts.