General cardinality feature updates #382

mpsonntag · 2020-04-15T09:52:10Z

This PR is a preparation for the introduction of Section-section and Section-property cardinality features to keep PRs at a size that is still convenient to review.

The PR introduces

a generalization of the cardinality function for later reuse by different cardinalities
catches some edge cases in the core cardinality function
filters the validation warnings when checking for cardinality violations to display only warning messages specific to the validated object and not from connected objects as well.
adds and updates tests where required

Replaced value_cardinality implementation with usage of the more generic util.format_cardinality function.

When running a values cardinality validation filter the warnings to only those that are relevant for the validated object.

coveralls · 2020-04-15T10:13:10Z

Coverage increased (+0.02%) to 76.39% when pulling 6aa02e4 on mpsonntag:cardUpdates into 7dde867 on G-Node:master.

jgrewe

lgtm

odml/util.py

mpsonntag added 8 commits April 14, 2020 16:37

[util] Add format_cardinality func

5428a92

[test/util] Add format_cardinality test

5287065

[property] Use util.format_cardinality

019c87b

Replaced value_cardinality implementation with usage of the more generic util.format_cardinality function.

[util] Handle cardinality empty tuple edgecase

5f10714

[util] Handle exact val cardinality edge case

7a5fd79

[property] Move cardinality val to own func

b248516

[property] Filter warnings on cardinality validate

c325e85

When running a values cardinality validation filter the warnings to only those that are relevant for the validated object.

[test/validation] Add clear output method

27cb745

jgrewe approved these changes Apr 15, 2020

View reviewed changes

odml/util.py Outdated Show resolved Hide resolved

[util] Allow list in cardinality

6aa02e4

achilleas-k approved these changes Apr 15, 2020

View reviewed changes

achilleas-k merged commit eccae1f into G-Node:master Apr 15, 2020

mpsonntag deleted the cardUpdates branch April 15, 2020 17:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General cardinality feature updates #382

General cardinality feature updates #382

mpsonntag commented Apr 15, 2020

coveralls commented Apr 15, 2020 •

edited

Loading

jgrewe left a comment

General cardinality feature updates #382

General cardinality feature updates #382

Conversation

mpsonntag commented Apr 15, 2020

coveralls commented Apr 15, 2020 • edited Loading

jgrewe left a comment

Choose a reason for hiding this comment

coveralls commented Apr 15, 2020 •

edited

Loading