Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDF Subclassing feature #400

Merged
merged 11 commits into from
Jul 16, 2020
Merged

RDF Subclassing feature #400

merged 11 commits into from
Jul 16, 2020

Conversation

mpsonntag
Copy link
Contributor

This PR closes issue #397 and its sub-issues #394, #395 and #396.

RDF subclasses are now properly added by default to any written RDF document. The RDF document will now also include RDF Subclass definitions in addition to the actual data (see issue #396) to enable Subclass specific queries.

@coveralls
Copy link

coveralls commented Jul 14, 2020

Coverage Status

Coverage increased (+0.1%) to 80.689% when pulling 41d72b0 on mpsonntag:rdf_subclass into 7a1ca1f on G-Node:master.

Copy link
Member

@jgrewe jgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One tiny recommendation.

odml/tools/rdf_converter.py Outdated Show resolved Hide resolved
In homage to the unknown DAU all whitespaces are excluded
from the custom RDF subclasses dict.
@achilleas-k achilleas-k merged commit c03d5cf into G-Node:master Jul 16, 2020
@mpsonntag mpsonntag mentioned this pull request Jul 16, 2020
3 tasks
@mpsonntag mpsonntag deleted the rdf_subclass branch July 17, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants