fix: properly handle comparing zero versions in Maven (#173)

G-Rath · Mar 3, 2023 · a03cbc9 · a03cbc9
1 parent cc0ea00
commit a03cbc9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/pkg/semantic/fixtures/maven-versions.txt b/pkg/semantic/fixtures/maven-versions.txt
@@ -108,3 +108,16 @@
 123456789012345.1H.5-beta < 12345678901234567890.1H.5-beta
 1234567890.12345 < 12345678901234567890.1H.5-beta
 20190126.230843 < 12345678901234567890.1H.5-beta
+
+# https://github.com/google/osv.dev/pull/1021
+0.0.0 = 0.0
+0.0.0 = 0
+0.0 = 0
+0 = 0
+
+0.0.0-0.0.0 = 0-final-ga
+0.0.0-0.0.0 = 0
+0-final-ga = 0
+
+0 < 1
+0.0.0-2021-05-17T01-01-51-5ec03a8b < 20.0.0
diff --git a/pkg/semantic/version-maven.go b/pkg/semantic/version-maven.go
@@ -283,7 +283,7 @@ func newMavenVersion(str string) MavenVersion {
 
 	i := len(tokens) - 1
 
-	for i >= 0 {
+	for i > 0 {
 		if tokens[i].shouldTrim() {
 			tokens = append(tokens[:i], tokens[i+1:]...)
 			i--