Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use name and version properties if present when parsing pnpm.yaml locks #106

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

G-Rath
Copy link
Owner

@G-Rath G-Rath commented Jun 11, 2022

When researching how pnpm represents git dependencies in it's lock to support extracting commits, I found out a bit more on how the dependencies paths work.

Turns out pnpm captures the name and version within the dependency path if possible, otherwise it includes them as a property - so if either of those properties are present we should favor them over whatever we extract from the dependency path.

This has also highlighted that this parser is probably the most inaccurate, but I'm not too fussed because it should only be falling over on exotic cases and I've not got a lot of easy reference to confirm what is and isn't correct so for now I'll have to rely on people opening issues if they find something is not being parsed correctly.

@G-Rath G-Rath merged commit fe0446d into main Jun 11, 2022
@G-Rath G-Rath deleted the improve-pnpm-parser branch June 11, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant