fix: handle cyclical -rs in requirements.txt files
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this is not actually supported by `pip` itself, but doing so actually optimizes the parser a bit anyway by only reading each file exactly once regardless of how often it is required
robotdana
reviewed
May 4, 2023
| filepath.Join(filepath.Dir(pathToLockfile), strings.TrimPrefix(line, "-r ")), | ||
| ) | ||
| if ar := strings.TrimPrefix(line, "-r "); ar != line { | ||
| ar = filepath.Join(filepath.Dir(pathToLockfile), ar) |
There was a problem hiding this comment.
is there some path expansion/resolution that that would deal with e.g. ./../pip/cyclic-r-complex-1.txt is the same as ./../pip/../pip/cyclic-r-complex-1.txt
There was a problem hiding this comment.
Yup that's handled by filepath.Join which Cleans the path after the join
robotdana
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is not actually supported by
pipitself, but doing so actually optimizes the parsera bit anyway by only reading each file exactly once regardless of how often it is required