Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "All required checks succeeded" check run when "All required checks done" CI job is actually successful #367

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

jgiannuzzi
Copy link
Member

The "All required checks done" CI job has been designed to be a required check, but GitHub considers it successful when it's skipped, and it gets skipped when some of the jobs it depends on fail. A first attempt at fixing that was made in #366 but it was not enough.

This PR fixes that by checking in a separate workflow whether the job conclusion is success and creates a new check run "All required checks succeeded" when it's the case. When it's not the case, the check run is not created and PRs will thus not be mergeable.

Example runs:

I changed the workflow output slightly to show a ❌ when "All required checks done" is not successful, but this is not reflected in the above examples.

@adamreeve adamreeve merged commit 47e6cbf into G-Research:master Aug 15, 2023
25 checks passed
@jgiannuzzi jgiannuzzi deleted the fix-required-checks branch August 16, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants