Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up LogicalBatchReader/Writer into separate files #371

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Split up LogicalBatchReader/Writer into separate files #371

merged 3 commits into from
Sep 10, 2023

Conversation

philjdf
Copy link
Contributor

@philjdf philjdf commented Sep 9, 2023

Just a small PR so it's easier to navigate around that part of the code (with a view to subsequently having a go at adding a Skip method to LogicalColumnReader).

adamreeve
adamreeve approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Phil

@adamreeve adamreeve merged commit 323b6f1 into G-Research:master Sep 10, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreeve adamreeve adamreeve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philjdf @adamreeve