Upgrade the NUnit test adapter #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the tests under Visual Studio Code with the C# Dev Kit extension would include tests marked explicit, leading to surprises like the
StressTestProcessMemorytest running for a long time. This is fixed by upgrading the version of theNUnit3TestAdapterpackage, but this also seems to have changed behaviour so that now any console logging from tests is output by default when runningdotnet test. The tests were doing a lot of logging, over 80k lines, so I've also removed some logging I thought was unnecessary and changed some logs to only be shown in the case of an error where they add some useful context.