Write vcpkg arrow port ABI info in CI #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help us understand why vcpkg sometimes fails to use cached previous builds
marcin-krystianc
approved these changes
Oct 17, 2023
| run: cat ./build/${{ steps.vcpkg-info.outputs.triplet }}-release/vcpkg_installed/${{ steps.vcpkg-info.outputs.triplet }}/share/arrow/vcpkg_abi_info.txt | ||
| - name: Dump vcpkg arrow abi info (Windows) | ||
| if: runner.os == 'Windows' | ||
| run: Get-Content ./build/${{ steps.vcpkg-info.outputs.triplet }}/vcpkg_installed/${{ steps.vcpkg-info.outputs.triplet }}/share/arrow/vcpkg_abi_info.txt |
There was a problem hiding this comment.
nit: I think it is possible to use powershell or unix tools on all OSes, so there is no need to do it conditionally. But doing it conditionally is fine too.
There was a problem hiding this comment.
So I originally just had one job for all OSs, as powershell recognizes cat as an alias for Get-Content, but the Windows path is slightly different and doesn't have the extra "-release". I could probably figure out how to add that conditionally, but it seemed easier just to have separate jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help us understand why vcpkg sometimes fails to use cached previous builds