Copy vcpkg.json before cloning vcpkg in devcontainer Dockerfile #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should ensure the baseline referenced by vcpkg.json exists in the cached vcpkg git checkout.
adamreeve
force-pushed
the
devcontainer-fix
branch
from
e5d8e31
to
9b49a5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to Arrow 14.0.2 the devcontainer build failed due to not finding that Arrow version in vcpkg (https://github.com/G-Research/ParquetSharp/actions/runs/7458957587/job/20293957096), although the devcontainer build had passed in the PR.
It looks like this is because the docker build used a cached result of checking out the vcpkg repository from before Arrow 14.0.2 was added.
I've moved the copy of vcpkg.json to before the vcpkg repo checkout, so any changes to vcpkg.json should force a new checkout of vcpkg rather than use the previously cached result.