Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caching to save time on CodeQL analysis #410

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

ljubon
Copy link
Contributor

@ljubon ljubon commented Jan 11, 2024

After #392 this PR should save time on CodeQL run

Example run on forked repo: https://github.com/ljubon/ParquetSharp/actions/runs/7493616704/job/20399707365

@ljubon ljubon mentioned this pull request Jan 11, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please split up the "sudo apt-get update..." step, moving the "apt-get" commands before "InitializeCodeQL", and make sure all the steps have a name

.github/workflows/codeql-analysis.yml Outdated Show resolved Hide resolved
@adamreeve
Copy link
Contributor

adamreeve commented Jan 11, 2024

I'm seeing CodeQL issues show up in the security tab for things that are in our C++ dependencies, which I don't think we should include here. Those will probably be excluded if we get prebuilt dependencies from the cache, but that won't work every time.

From the CodeQL docs (https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning#specifying-directories-to-scan), you can only ignore paths for interpreted languages, so we need to somehow split out the build of the C++ dependencies from the build of the ParquetSharp C++ library. Currently that all happens together in build_unix.sh when we run the CMake build. I don't know if there's an easy way to first build all the dependencies.

If this is too hard to fix it's probably fine to leave this as is.

adamreeve
adamreeve previously approved these changes Jan 12, 2024
@adamreeve adamreeve removed the request for review from marcin-krystianc January 12, 2024 09:23
@adamreeve adamreeve merged commit 307a2bd into G-Research:master Jan 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants