Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "All required checks succeeded" check run when "All required checks done" CI job is actually successful #241

Merged
merged 2 commits into from Aug 15, 2023

Conversation

jgiannuzzi
Copy link
Member

The "All required checks done" CI job has been designed to be a required check, but GitHub considers it successful when it's skipped, and it gets skipped when some of the jobs it depends on fail. A first attempt at fixing that was made in #237 but it was not enough.

This PR fixes that by checking in a separate workflow whether the job conclusion is success and creates a new check run "All required checks succeeded" when it's the case. When it's not the case, the check run is not created and PRs will thus not be mergeable.

Example runs:

I changed the workflow output slightly to show a ❌ when "All required checks done" is not successful, but this is not reflected in the above examples.

@jgiannuzzi jgiannuzzi changed the title Check how we create the required check by using a separate workflow Create "All required checks succeeded" check run when "All required checks done" CI job is actually successful Aug 15, 2023
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a little cuckoo that Github workflows don't stop on a failure without such a script -- isn't that CI 101?

@jgiannuzzi
Copy link
Member Author

it is super sad indeed — all I want is for required checks to mean: "successful and not skipped" and not this bizzaro "skipped is considered the same as successful"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants