Rewrite the required checks process to look for check runs of the commit #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were looking for the corresponding workflow runs, which could cause all kinds of race conditions. We now always get the latest info from the API instead of relying on what we received, which might be out of date by the time we actually run.
jgiannuzzi
force-pushed
the
required-checks-rewrite
branch
from
3d23960
to
748dace
Compare
suprjinx
approved these changes
Oct 17, 2023
dsuhinin
approved these changes
Oct 17, 2023
This was referenced Oct 18, 2023
suprjinx
pushed a commit
to suprjinx/fasttrackml
that referenced
this pull request
Oct 23, 2023
…mit (G-Research#473) We were looking for the corresponding workflow runs, which could cause all kinds of race conditions. We now always get the latest info from the API instead of relying on what we received, which might be out of date by the time we actually run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were looking for the corresponding workflow runs, which could cause all kinds of race conditions. We now always get the latest info from the API instead of relying on what we received, which might be out of date by the time we actually run.
Here is the example of a dependabot pull request, which essentially creates 2 different runs (one for the
pull_requestevent and one for thepushevent). Thepull_requestevent results in a skipped run, and thepushevent eventually succeeds.check-required.ymlworkflow runs for the first time, its summary looks like this:pushevent run eventually succeeds, thecheck-required.ymlworkflow run that gets triggered looks like this: