Remove the goimport check #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For starters, the name is `Check formatting` and it does not check formatting. It checks imports. But: The tool itself cannot cope with the `golang.org/x/tools` package: if you add the checksum it says via `go mod download` it then complains you need to `go mod tidy`, which then removes that checksum. ``` go: downloading golang.org/x/tools v0.0.0-20201201161351-ac6f37ff4c2a go: updates to go.mod needed; to update it: go mod tidy ``` vs ``` missing go.sum entry for module providing package golang.org/x/tools/cmd/goimports; to add: go mod download golang.org/x/tools ``` ```
greed42
added a commit
that referenced
this pull request
Dec 28, 2022
It just makes more things mad. PR #100 to turn off the checker since it can't cope.
<https://cs.opensource.google/go/x/tools/+/master:cmd/goimports/goimports.go> actually also does gofmt. So that's not obvious from the name.... But we can't even use it in `--format-only` mode, it still whines about the go.sum entry that it then wants you to go mod tidy away. So just use gofmt.
|
Lgtm, but also check failures |
eswdd
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For starters, the name is
Check formattingand it does not check formatting. It checks imports.But: The tool itself cannot cope with the
golang.org/x/toolspackage: if you add the checksum it says viago mod downloadit then complains you need togo mod tidy, which then removes that checksum.vs