Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A simple faketsdb #43

Merged
merged 2 commits into from
Oct 4, 2019
Merged

A simple faketsdb #43

merged 2 commits into from
Oct 4, 2019

Conversation

dgl
Copy link
Contributor

@dgl dgl commented Oct 3, 2019

No description provided.

@dgl dgl requested a review from robincw-gr October 3, 2019 15:32
@eswdd
Copy link
Contributor

eswdd commented Oct 3, 2019

Boo hiss ;)

@robincw-gr
Copy link
Member

Yay, no npm. However, I don't feel it belongs in Geras until there is a Geras test that requires it.

@dgl
Copy link
Contributor Author

dgl commented Oct 3, 2019

Indeed, my plan is to have something bring it up in Docker and use as an integration test of some kind. I'd prefer to merge it so I don't have to juggle multiple branches and CircleCI...

(In general I'm for merging small changes to head ASAP, less merging needed then...)

Copy link
Member

@robincw-gr robincw-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with docker-compose.yml:

faketsdb:
  image: golang:alpine
  ports:
    - 8080:8080
  volumes:
    - ./test:/app
  command: ["go", "run", "/app/faketsdb.go"]

geras:
  build: .
  ports:
    - 19000:19000
    - 19001:19001
  links:
    - faketsdb
  command:
    - "-log.level=debug"
    - "-opentsdb-address=faketsdb:8080"
    - "-trace-dumpbody"
    - "-grpc-listen=:19000"
    - "-http-listen=:19001"

thanos:
  image: thanosio/thanos:v0.7.0
  ports:
    - 10902:10902
  links:
    - geras
  command: ["query", "--store=geras:19000"]

test/faketsdb.go Outdated Show resolved Hide resolved
@dgl dgl merged commit 873a4a4 into master Oct 4, 2019
@dgl dgl deleted the faketsdb branch October 27, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants