Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo folder #94

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Add logo folder #94

merged 4 commits into from
Jan 19, 2022

Conversation

debiday
Copy link
Contributor

@debiday debiday commented Dec 16, 2021

Added a docs folder with logos inside to keep the main folder clean

@debiday
Copy link
Contributor Author

debiday commented Jan 5, 2022

Hi @jgiannuzzi, happy new year! Can I trouble you to check if adding the logos to the docs folder is appropriate here? Thank you 😊

@jgiannuzzi
Copy link
Member

Hey @debiday, happy (belated) new year to you too!

As there is currently no docs folder, I feel like the logos should instead be in logo folder at the root, like we did for ParquetSharp (this is just my opinion, feel free to argue differently!)

Could you also remove the existing logo.svg and update the README to point to the equivalent file inside the new logo folder?

@debiday
Copy link
Contributor Author

debiday commented Jan 18, 2022

Thank you @jgiannuzzi for the suggestion! It makes sense. Took a few commits, sorry, but I think it's all set now. Removed the logo.svg, replaced the docs folder with just the logo folder, and replaced and resized the logo in the readme 😊

@jgiannuzzi jgiannuzzi changed the title add docs folder with logo folder inside Add logo folder Jan 19, 2022
Copy link
Member

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Thanks, @debiday!

@jgiannuzzi jgiannuzzi merged commit bcf7cff into G-Research:master Jan 19, 2022
@debiday
Copy link
Contributor Author

debiday commented Jan 20, 2022

Thank you for the suggestions and approval @jgiannuzzi! ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants