Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config-editor-ui: Reworking Config testers based on new backend #750

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

config-editor-ui: Reworking Config testers based on new backend #750

wants to merge 10 commits into from

Conversation

yasram1
Copy link
Contributor

@yasram1 yasram1 commented Aug 3, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 3, 2022 •
edited
Loading

Unit Test Results

1 152 tests  ±0   1 147 ✔️ ±0   1m 36s ⏱️ -2s
   123 suites ±0          5 💤 ±0 
   123 files   ±0          0 ❌ ±0 

Results for commit 0e84f03. ± Comparison against base commit 7861644.

♻️ This comment has been updated with latest results.

cmv13
cmv13 suggested changes Aug 3, 2022
View reviewed changes
config-editor/config-editor-ui/src/app/components/editor-view/editor-view.component.ts Outdated Show resolved Hide resolved
config-editor/config-editor-ui/src/app/components/release-dialog/release-dialog.component.ts Outdated Show resolved Hide resolved
...ditor/config-editor-ui/src/app/components/testing/config-testing/config-testing.component.ts Outdated Show resolved Hide resolved
...ditor/config-editor-ui/src/app/components/testing/config-testing/config-testing.component.ts Outdated Show resolved Hide resolved
...ditor/config-editor-ui/src/app/components/testing/config-testing/config-testing.component.ts Outdated Show resolved Hide resolved
...ditor/config-editor-ui/src/app/components/testing/config-testing/config-testing.component.ts Outdated Show resolved Hide resolved
...r/config-editor-ui/src/app/components/testing/test-case-editor/test-case-editor.component.ts Outdated Show resolved Hide resolved
config-editor/config-editor-ui/src/app/services/editor.service.ts Outdated Show resolved Hide resolved
config-editor/config-editor-ui/src/app/components/testing/test-centre/test-centre.component.ts Outdated Show resolved Hide resolved
config-editor/config-editor-ui/src/app/services/config-loader.service.ts Show resolved Hide resolved
mariannovotny
mariannovotny suggested changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@mariannovotny mariannovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR needs to be reworked - to support different testers per release test config test cases

config-editor/config-editor-ui/src/app/model/config-model.ts Outdated Show resolved Hide resolved
config-editor/config-editor-ui/src/app/components/release-dialog/release-dialog.component.ts Outdated Show resolved Hide resolved
config-editor/config-editor-ui/src/app/services/editor.service.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmv13 cmv13 cmv13 requested changes

@mariannovotny mariannovotny mariannovotny requested changes

@tgilgs tgilgs Awaiting requested review from tgilgs tgilgs is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yasram1 @cmv13 @mariannovotny