This repository has been archived by the owner on Jun 11, 2022. It is now read-only.
Support for legacy stack #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 2, 2017 17:28
Nothing works, mind you, but you can bundle install without errors
There are still failing tests all over the place
maeve
force-pushed
the
if-i-could-turn-back-time
branch
from
770e484
to
ddc8bcd
Compare
added 16 commits
November 2, 2017 21:37
Required for compatibility with rails 3.x
Hopefully this increases the likelihood that travis will use a precompiled binary
It messes with frozen string literals and we absolutely do not care about supporting this particular combination of dependencies
Ruby 2.4 is not supported before rails 4.2.8
We don't actually need any plain text responses, and it breaks horribly under newer versions of rails
maeve
force-pushed
the
if-i-could-turn-back-time
branch
from
b02f499
to
efc78ca
Compare
ryankbales
approved these changes
Dec 14, 2017
|
|
||
| ActiveRecord::Schema.define(version: 20140113233821) do | ||
| ActiveRecord::Schema.define(:version => 20140113233821) do | ||
|
|
There was a problem hiding this comment.
Why the switch to the hash rocket syntax?
There was a problem hiding this comment.
Because rails didn't introduce the new hash syntax in the schema generation until rails 4.1, but the dev environment is now using rails 3.2. I didn't add any migrations as part of this pull request, but I did have to run db:test:prepare, which dumps a new schema file in order to load it into the test db.
levibrown
approved these changes
Dec 14, 2017
| # rails 5 (which does not support *_filter callbacks) | ||
| set_callback :process_action, :before, :require_no_authentication, | ||
| if: ->(c) { [:new, :create].include?(c.action_name) }, | ||
| prepend: true |
added 5 commits
January 23, 2018 14:29
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to support a specific stack in order to integrate with certain legacy apps:
I made sure we have a complete build matrix for supported ruby/rails/devise combinations. For now, at least, we're able to accommodate them all with a single version of this gem.
https://www.pivotaltracker.com/story/show/150988086