Merge pull request #5 from G5/fix_less_than_rails_4-2_issue

Fix issue when deleting keys.

.gitignore

@@ -9,3 +9,4 @@ spec/dummy/tmp/
 spec/dummy/.sass-cache
 spec/dummy/config/database.yml
 tmp
+gemfiles/*.lock

Appraisals

@@ -0,0 +1,7 @@
+appraise "rails_4.1_and_below" do
+  gem "rails", "4.1"
+end
+
+appraise "rails_4.2_and_above" do
+  gem "rails", "4.2"
+end

CHANGELOG.md

@@ -1,3 +1,7 @@
+# TBA
+
+- Fix bug when deleting keys
+
 # 1.0.0
 
 - Expose class method `storext_definitions` to list defined Storext attributes

Gemfile

@@ -11,3 +11,5 @@ gemspec
 # your gem to rubygems.org.
 
 gem 'pry'
+
+gem 'appraisal'

gemfiles/rails_4.1_and_below.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "pry"
+gem "appraisal"
+gem "rails", "4.1"
+
+gemspec :path => "../"

gemfiles/rails_4.2_and_above.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "pry"
+gem "appraisal"
+gem "rails", "4.2"
+
+gemspec :path => "../"

lib/storext/instance_methods.rb

@@ -3,6 +3,9 @@ module InstanceMethods
 
     def destroy_key(column, attr)
       new_value = send(column)
+      if Rails.gem_version < Gem::Version.new("4.2.0")
+        new_value = send(column).dup
+      end
       new_value.delete(attr.to_s)
       send("#{column}=", new_value)
     end

spec/storext_spec.rb

@@ -165,6 +165,17 @@
       book.reload
       expect(book.data).to have_key("author")
     end
+
+    it "updates the changes when saved" do
+      book = Book.create
+      book.data = {'hulla' => 'balloo'}
+      book.save
+      expect(book.data['hulla']).to eq 'balloo'
+      book.destroy_key(:data, :hulla)
+      book.save
+      book.reload
+      expect(book.data).to_not have_key("hulla")
+    end
   end
 
   describe ".destroy_keys" do