Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Correct the order of the parameters for the FPCA in Mahalanobis #506

Merged
merged 5 commits into from
Jan 26, 2023

Conversation

m5signorini
Copy link
Contributor

@m5signorini m5signorini commented Jan 14, 2023

The constructor for FPCA receives parameters in a different order than the one used in Mahalanobis.

def __init__(
self,
n_components: int = 3,
centering: bool = True,
regularization: Optional[L2Regularization[FData]] = None,
components_basis: Optional[Basis] = None,
_weights: Optional[Union[ArrayLike, WeightsCallable]] = None,
) -> None:

Thus, the last two parameters should be interchanged in the call to the constructor in Mahalanobis.

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Base: 85.53% // Head: 85.53% // No change to project coverage 👍

Coverage data is based on head (af8aafb) compared to base (42d0cdb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #506   +/-   ##
========================================
  Coverage    85.53%   85.53%           
========================================
  Files          141      141           
  Lines        11280    11280           
========================================
  Hits          9648     9648           
  Misses        1632     1632           
Impacted Files Coverage Δ
skfda/misc/metrics/_mahalanobis.py 83.72% <ø> (ø)
skfda/preprocessing/dim_reduction/_fpca.py 91.20% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@m5signorini m5signorini changed the title Reorder parameters for the FPCA in Mahalanobis Hotfix: Correct the order of the parameters for the FPCA in Mahalanobis Jan 14, 2023
@vnmabus vnmabus merged commit 2bd315d into develop Jan 26, 2023
@vnmabus vnmabus deleted the Mahalanobis/hotfix-fpca branch August 17, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants