Fix inner product integrate #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #522 +/- ##
===========================================
+ Coverage 85.63% 85.66% +0.02%
===========================================
Files 143 143
Lines 11384 11397 +13
===========================================
+ Hits 9749 9763 +14
+ Misses 1635 1634 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
vnmabus
requested changes
Mar 22, 2023
skfda/misc/_math.py
Outdated
| f1 = arg1(args)[:, 0, :] | ||
| f2 = arg2(args)[:, 0, :] | ||
| def integrand(*args: NDArrayFloat) -> NDArrayFloat: # noqa: WPS430 | ||
| f_args = cast(NDArrayFloat, args) |
skfda/tests/test_math.py
Outdated
| np.testing.assert_allclose( | ||
| skfda.misc.inner_product(fd, fd_basis), | ||
| res, | ||
| rtol=1e-4, |
There was a problem hiding this comment.
What is the actual tolerance? Can we put a lower rtol?
There was a problem hiding this comment.
The minimum tolerance for this test is of order 1e-14. It has been updated.
…UAM/scikit-fda into fix/inner_product_integrate
vnmabus
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when doing the inner product between different types of functional data objects (for example, between FDataGrid and FDataBasis) if the functions are multivariate, then the product fails.
This is an error that occurs when using the method
_inner_product_integrate, which is not usually called when dealing with the same types of functional objects.However, when using general
Callableobjects or when mixing types, it is called; failing when dealing with more than one variable.This pull request aims to solve this issue while adding a new test for the
inner_product. This test ensures that the product is correctly calculated betweenFDataGridandFDataBasisobjects.