Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename format check looks very strict #1

Closed
Antonytm opened this issue Mar 16, 2023 · 6 comments
Closed

Filename format check looks very strict #1

Antonytm opened this issue Mar 16, 2023 · 6 comments

Comments

@Antonytm
Copy link

I got an cumulative hotfix from Sitecore Support.
I want to look, what is inside. There are files named items.master.spe.dat and items.master.sxa.dat.

I try to open them. But I got an error:
image

@GAAOPS
Copy link
Owner

GAAOPS commented Mar 16, 2023

Hello @Antonytm,

many thanks for taking time and interest to this small repo. Please help me undrestand why do you need this change.

The sitecore protobuf files like "items.master.spe.dat" are containing sparse tree. for example:
image

The System and Modules items are not included inside the "items.master.spe.dat".
The sub module/protobuf files are ment to be small and used in combination with the main files (items.master.dat/items.core.dat/items.web.dat).

There is not an easy way to visualize (as a tree) one of this modules or secondary serialized file without having a main file.

That is the reason that i set a strict validation to include the relevant main file (items.master.dat/items.core.dat/items.web.dat).
Removing the restriction may cause more confusion.

You can select the main file and the secondary file (spe/sxa, ....) to have a full tree.

I undrestand you want to see the items from the package only, i think i can add some sort of filtering to the app.
Currently you have a minimum option, which mark the secondary items (powershell) as red, i can make it more visible with basically hiding the other part of the tree which are not relevant for the secondary package.

Looking forward to hear your opinion.

@GAAOPS
Copy link
Owner

GAAOPS commented Mar 16, 2023

I have just added the filtering and creating a release.
The Read.ME is updated.

@Antonytm
Copy link
Author

@GAAOPS
Use case: I got a hotfix from support. I want to understand, what files are included.

@GAAOPS
Copy link
Owner

GAAOPS commented Mar 16, 2023

@Antonytm , you can not open the files as stand alone without the main file, in the file dialog you need to select both for example:
sitecore.master.dat and the the hotfix from support or
sitecore.core.dat and the the hotfix from support.
after that if you are using the release 1.0.1 you can use filtering to filter it down to the items from the support package.

Sitecore modules and basically secondary files are kind of sparse tree, that means they do not include the whole tree of the master/core/web database. because of that you need to always have a relevant data at hand(ex. items.master.dat) and select it with the relevant module.

@Antonytm
Copy link
Author

@GAAOPS

Thank you for this detailed explanation!

Actually, I didn't know that hotfix support files are different. Sorry for initial confusion.

@GAAOPS
Copy link
Owner

GAAOPS commented May 31, 2023

@Antonytm , i will close this issue and your PR, I think everything should be clear for now.

@GAAOPS GAAOPS closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants