This repository has been archived by the owner on Jul 16, 2022. It is now read-only.
Add roleinfo command #394
Merged
Gilbert142
merged 8 commits into
GAwesomeBot:indev-4.0.2
from
wasdennnoch:new-commands-roleinfo
Dec 4, 2018
Merged
Add roleinfo command #394
Gilbert142
merged 8 commits into
GAwesomeBot:indev-4.0.2
from
wasdennnoch:new-commands-roleinfo
Dec 4, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilbert142
suggested changes
Dec 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nitpicks. Good PR otherwise!
embed: { | ||
title: `Information about role ${role.name} :: ${role.id}`, | ||
color: role.color || null, | ||
description: elements.join("\n"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single new-line might be too crowded. Consider using two instead?
Commands/Public/roleinfo.js
Outdated
title: "What's that role? 🏷️", | ||
description: "I do not know anything about a role with that name.", | ||
footer: { | ||
text: "You can find a list of all roles by simply executing this command without any arguments.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Simply Executing" -> "Running"
|
||
await new PaginatedEmbed(msg, { | ||
color: Colors.INFO, | ||
title: `This guild has ${guildRoles.length} roles`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title is inconsistent with title of non-paged message. (Missing ":")
Gilbert142
approved these changes
Dec 3, 2018
Gilbert142
added
type: Feature
Issues that request or implement a new feature or module
target: Commands
Issues that target Command files
s: Committed
Non-bug issues and PRs that have been committed/merged
labels
Dec 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
s: Committed
Non-bug issues and PRs that have been committed/merged
target: Commands
Issues that target Command files
type: Feature
Issues that request or implement a new feature or module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Throw it at me Vlad
What does this PR do:
commands.js