Skip to content
This repository has been archived by the owner on Jul 16, 2022. It is now read-only.

Add roleinfo command #394

Merged
merged 8 commits into from Dec 4, 2018
Merged

Add roleinfo command #394

merged 8 commits into from Dec 4, 2018

Conversation

wasdennnoch
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Throw it at me Vlad

What does this PR do:

  • This PR changes internal functions, modules and/or utilities
    • This PR modifies the Extension API
  • This PR modifies commands
    • This PR changes command functions
    • This PR changes metadata for the command, updated in commands.js
    • This PR removes and/or adds commands
  • This PR modifies Web processing and/or content
    • This PR modifies static/ejs content
    • This PR modifies request processing (endpoint functions)
    • This PR modifies paths to existing resources
  • This PR only includes non-code changes, like changes to default configurations, README, typos, etc.

Copy link
Member

@Gilbert142 Gilbert142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks. Good PR otherwise!

Commands/Public/roleinfo.js Show resolved Hide resolved
embed: {
title: `Information about role ${role.name} :: ${role.id}`,
color: role.color || null,
description: elements.join("\n"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single new-line might be too crowded. Consider using two instead?

title: "What's that role? 🏷️",
description: "I do not know anything about a role with that name.",
footer: {
text: "You can find a list of all roles by simply executing this command without any arguments.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Simply Executing" -> "Running"


await new PaginatedEmbed(msg, {
color: Colors.INFO,
title: `This guild has ${guildRoles.length} roles`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title is inconsistent with title of non-paged message. (Missing ":")

@Gilbert142 Gilbert142 added type: Feature Issues that request or implement a new feature or module target: Commands Issues that target Command files s: Committed Non-bug issues and PRs that have been committed/merged labels Dec 3, 2018
@Gilbert142 Gilbert142 merged commit 8d590de into GAwesomeBot:indev-4.0.2 Dec 4, 2018
@wasdennnoch wasdennnoch deleted the new-commands-roleinfo branch April 22, 2019 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
s: Committed Non-bug issues and PRs that have been committed/merged target: Commands Issues that target Command files type: Feature Issues that request or implement a new feature or module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants