Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applying solid principles to calc_class.py #43

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

guilhermedelyra
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #43 (4f9fc06) into master (8bb3ce9) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #43      +/-   ##
=========================================
- Coverage    3.98%   3.94%   -0.04%     
=========================================
  Files          76      79       +3     
  Lines        4542    4587      +45     
  Branches      472     471       -1     
=========================================
  Hits          181     181              
- Misses       4360    4405      +45     
  Partials        1       1              
Impacted Files Coverage Δ
pydemic_ui/apps/calc_class.py 0.00% <0.00%> (ø)
pydemic_ui/apps/construct_model_class.py 0.00% <0.00%> (ø)
pydemic_ui/apps/debug_calc_class.py 0.00% <0.00%> (ø)
pydemic_ui/apps/secret_class.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb3ce9...4f9fc06. Read the comment docs.

Copy link

@RCristyan RCristyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solid principles were applied correctly and the code is good to merge.

@RCristyan RCristyan merged commit d2a2f51 into master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants