Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Move localized constants to backend #10634

Open
4 tasks
Tracked by #9692 ...
esizer opened this issue Jun 11, 2024 · 0 comments · May be fixed by #10701
Open
4 tasks
Tracked by #9692 ...

♻️ Move localized constants to backend #10634

esizer opened this issue Jun 11, 2024 · 0 comments · May be fixed by #10701
Assignees
Labels
debt Refactor or improve existing code.
Milestone

Comments

@esizer
Copy link
Member

esizer commented Jun 11, 2024

♻️ Debt/Refactor

Move our localized enum constants to the server.

🕵️ Details

We would like to start doing database value localization on the back end. So we are moving the localizedConstants.tsx file to laravel. A spike has been completed to figure out the approach to take

🙋‍♀️ Proposed Solution

You can use the spike PR created to do the implementation. Keeping in mind, we do not want to use the intermediaryKey portion. Any custom translations should be done separately.

✅ Acceptance Criteria

  • All (or most?) of the localizedConstants.tsx file has been moved to the server (laravel)
  • Models that use the constants updated to return the new LocalizedEnumString instead of just the enum value
  • Frontend updated to use the values from the server
  • Add some PPHUnit tests to ensure the API validation and expected results occur
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Refactor or improve existing code.
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

2 participants