Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Pool bookmark scope test intermittently failing #10651

Closed
1 task
esizer opened this issue Jun 12, 2024 · 0 comments · Fixed by #10776
Closed
1 task

🧪 Pool bookmark scope test intermittently failing #10651

esizer opened this issue Jun 12, 2024 · 0 comments · Fixed by #10776
Assignees
Labels
tests Procedures intended to establish the quality, performance, or reliability of something.

Comments

@esizer
Copy link
Member

esizer commented Jun 12, 2024

🧪 Tests

Noticed the PHP Unit for pool bookmarks test is failing somewhat frequently (~50%).

🕵️ Details

See the failing test here: https://github.com/GCTC-NTGC/gc-digital-talent/actions/runs/9484656388/job/26134649874?pr=10642#step:7:552

It looks like the created at date is random so the non-bookmarked ones are coming in at random orders which would back up to 50% fail rate. Maybe they are being created asynchronous? 😵‍💫

🙋‍♀️ Proposed Solution

Manually set created at date so the second and third so they remain consistent in order, or do a different secondary sort.

✅ Acceptance Criteria

  • Test consistently passes
@esizer esizer added the tests Procedures intended to establish the quality, performance, or reliability of something. label Jun 12, 2024
@JamesHuf JamesHuf self-assigned this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Procedures intended to establish the quality, performance, or reliability of something.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants