🐛 Notification pane background broken

[petertgiles]

🐛 Bug

The background "greyed out" overlay doesn't appear to be working. It doesn't appear until the pane is closed and then it prevents any interaction with the page.

📋 Steps to Reproduce

1. Open the notification pane.
2. Close the notification pane.
3. Attempt to use the site.

📸 Screenshot

simplescreenrecorder-2024-06-26_16.19.02.mp4

✅ Acceptance Criteria

• Background overlay appears when you open the pane.
• Background overlay disappears when you close the pane.
• You can interact with the site after closing the pane.
• Playwright/Jest test to confirm this is working

[vd1992]

I think this has to do with the children of <AnimatePresence /> in NotificationDialog.tsx
I wonder if it has to do with Vite and specifically Framer Motion stuff, there was other animation issues in the PR

See #10611 (comment)
I don't know if this commit had a role but could offer clues 5be2315

[vd1992]

isOpen switching from true -> false no longer disappears the nested elements and I can't figure out why it stopped working
The easiest fix is to just break the animation but don't want to resort to that

[petertgiles]

Seems like a dependency bump of Framer killed it. I did a manual bisect search and this PR broke the feature:
#10709

[brindasasi]

does reverting that pr get this up? If so I would vote to do that.

[petertgiles]

does reverting that pr get this up? If so I would vote to do that.

I just pushed up a PR that rolls back that dependency.