This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Add project codestyles #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Not sure if we should convert all sources within this PR or not 🤔 |
|
Hmm.. Since we don't have that much PR I would suggest to do it. 👍
…On Oct 2, 2017 12:37 PM, "rberghegger" ***@***.***> wrote:
@passsy <https://github.com/passsy> Good point. Was thinking about that
as well. 🤔 But I wanted to wait for your and @StefMa
<https://github.com/stefma> opinions before actually applying those
styles.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#123 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJwYe73W_Edmbo_6khBEr8UL1pk25O7xks5soLzpgaJpZM4Pqc0S>
.
|
added 3 commits
October 2, 2017 13:25
|
true, just do it. If there are conflicts we can solve them by applying the code style as well |
added 8 commits
October 2, 2017 13:34
|
Done. I've applied the new project codestyle to every module individually. Additionally I've added |
|
I would suggest to remove the TK from the contribution file. Also start with a single # and use two for code style... 👍 rest lgtm |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #122
As discussed in #122 this pull request adds project specific code styles based on the grandcentrix android code styles (https://github.com/grandcentrix/androidcodestyle) to the project.