Add deliverLatestToView to rx2/RxTiPresenterUtils #137
Conversation
Fix imports
| /** | ||
| * Returns a transformer that will delay onNext, onError and onComplete emissions unless a view | ||
| * become available. getView() is guaranteed to be != null during all emissions. This | ||
| * transformer can only be used on application's main thread. |
There was a problem hiding this comment.
I must admit, when I wrote the rx1 version I copied most of the docs.
Actually the main thread restriction is not true it's only recommended to make sure the view is always non null. Attach/Detach happens on the main thread. When code executes on any other thread it's not guaranteed that those actions happen before the view attach/detach state changes. So it may happen that the emission of T happens after the view got detached.
There was a problem hiding this comment.
I'm happy to rewrite the comment. The behaviour should be clear from the tests anyway, I hope.
|
|
||
| @Test | ||
| public void testDeliverLatestToView_SingleItemViewComesAndGoes() throws Exception { |
There was a problem hiding this comment.
We should add this test to rx1 as well. I'm actually not sure this is working.
There was a problem hiding this comment.
For that I've created a new issue. See #138
There was a problem hiding this comment.
Thank @GrahamBorland!
Fine for me but I want @StefMa to look at this as well
|
Comment adjusted, thanks. |
This adds an implementation of
deliverLatestToViewto rx2/RxTiPresenterUtils.It uses only existing RxJava2 operators, rather than the
OperatorSemaphorefrom the Rx1 utils. I did initially try to portOperatorSemaphorebut it quickly became terrifying.I have not implemented the other two (
deliverLatestCacheToViewanddeliverToView) since I have no use for them yet, and I'm not really sure what they are meant to do anyway. (Their documentation is confusing - see #34).Partial fix for #9.