-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix root path for export on krita4.3 #42
Conversation
In the way that the name of the root node is replaced by 'export' on the plugin does not work with krita 4.3, that causes that the exports where created in the same folder of the kra file, instead of in a folder. That was not a big issue per se but it also broke the COA exports. |
Thanks for your contribution! Here's an issue remaining: Exports like so: It should all be in Here's the file for testing: |
We should start to keep some test document and maybe have a regression test? |
Now everything is created inside of the export folder, anyway I don't know if everything is working fine with the COA export because I don't know how it should work in that case. |
@larpon, do you have a sample krita file we could use to test the exporter with COA tools? A simple file with a real-world character with the correct JSON/export we could keep in the repo for automated testing would be great, that way we can try exporting from new versions of the add-on to COA tools and see if it breaks. |
@NathanLovato - yes, sure I'll cook something up |
Just tested everything, looking great, thanks much! |
I'm merging manually to fix conflicts |
IMHO we should avoid using |
Merged manually in 2082395 |
Forget my previous comments, re-reading the code and thread I see I should've drank some more coffee this morning. I'll clean up the changes. Sorry for the hasty merges! |
Done, should be all good now. Thanks for your contribution! |
@NathanLovato I have another idea, the last one 😄, we should expose a way for allowing the user to use nearest-neighbor (NN) as interpolation algorithm, most of the time you want smooth interpolation, but for those doing pixel art is better to use NN for up-scaling. |
No description provided.