Fix root path for export on krita4.3

[leiserfg]

No description provided.

[leiserfg]

In the way that the name of the root node is replaced by 'export' on the plugin does not work with krita 4.3, that causes that the exports where created in the same folder of the kra file, instead of in a folder. That was not a big issue per se but it also broke the COA exports.
This patch is intended to fix the bug without breaking backward compatibility.

[NathanLovato]

Thanks for your contribution!

Here's an issue remaining:

Exports like so:

It should all be in export/, and 3.png should be in export/Layer_4/Layer_5/3.png

Here's the file for testing:

test.zip

[NathanLovato]

We should start to keep some test document and maybe have a regression test?

[leiserfg]

Now everything is created inside of the export folder, anyway I don't know if everything is working fine with the COA export because I don't know how it should work in that case.
I replaced the use of os.path with pathlib to make the implementation easier to read and to avoid doing manual path separation/joins because it can be problematic on windows and I have no windows to test.

[NathanLovato]

@larpon, do you have a sample krita file we could use to test the exporter with COA tools? A simple file with a real-world character with the correct JSON/export we could keep in the repo for automated testing would be great, that way we can try exporting from new versions of the add-on to COA tools and see if it breaks.

[larpon]

@NathanLovato - yes, sure I'll cook something up

[larpon]

@NathanLovato

Test files: #44
Fix for recent changes: #43

[NathanLovato]

Just tested everything, looking great, thanks much!

[NathanLovato]

I'm merging manually to fix conflicts

[leiserfg]

IMHO we should avoid using os.path.sep at all because it does not work that well in windows (there both / and \ are valid). That's why I'm using pathlib.

[NathanLovato]

Merged manually in 2082395

[NathanLovato]

Ah, I hadn't paid attention. @larpon is there any reason you're not using os.path.join? @leiserfg is there something pathlib does that os.path can't handle well?

[NathanLovato]

Forget my previous comments, re-reading the code and thread I see I should've drank some more coffee this morning. I'll clean up the changes. Sorry for the hasty merges!

[NathanLovato]

Done, should be all good now. Thanks for your contribution!

[leiserfg]

@NathanLovato I have another idea, the last one 😄, we should expose a way for allowing the user to use nearest-neighbor (NN) as interpolation algorithm, most of the time you want smooth interpolation, but for those doing pixel art is better to use NN for up-scaling.